Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Serial monitor lines not to wrap lines #697

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Dec 16, 2021

Why

currently, lines plotted to the serial plotter have fixed height, as a this is required for the virtual scroll to work properly and guarantee good performance.

This causes longer lines to wrap and overflow over the line below, causing a glitch in the ui (see picture)

image

How

Setting the white-space: nowrap; property fixes the issue allowing the whole panel to scroll horizontally
image

@fstasi fstasi requested a review from AlbyIanna December 16, 2021 15:42
@per1234 per1234 linked an issue Dec 16, 2021 that may be closed by this pull request
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fstasi fstasi merged commit 11a6959 into main Dec 20, 2021
@fstasi fstasi deleted the serial-monitor-glitch branch December 20, 2021 13:56
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: serial monitor Related to the Serial Monitor labels Oct 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serial Monitor overwriting lines of text
4 participants